Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: pkg/analyzer/lib/src/services/formatter_impl.dart

Issue 145953006: Remove workaround for missing setter function returns (dartbug.com/15914). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/services/formatter_impl.dart
===================================================================
--- pkg/analyzer/lib/src/services/formatter_impl.dart (revision 32086)
+++ pkg/analyzer/lib/src/services/formatter_impl.dart (working copy)
@@ -831,16 +831,7 @@
preserveLeadingNewlines();
visitNodes(node.metadata, followedBy: newlines);
modifier(node.externalKeyword);
- //TODO(pquitslund): remove this workaround once setter functions
- //have their return types properly set (dartbug.com/15914)
- if (node.returnType == null && node.propertyKeyword != null) {
- var previous = node.propertyKeyword.previous;
- if (previous is KeywordToken && previous.keyword == Keyword.VOID) {
- modifier(previous);
- }
- } else {
- visitNode(node.returnType, followedBy: space);
- }
+ visitNode(node.returnType, followedBy: space);
modifier(node.propertyKeyword);
visit(node.name);
visit(node.functionExpression);
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698