Issue 1459513002: Fix for drmemory failure on I411ToARGB

Issue 1459513002: Fix for drmemory failure on I411ToARGB (Closed)

Created:
5 years, 1 month ago by fbarchard1

Modified:
5 years, 1 month ago

Reviewers:
harryjin, fbarchard

CC:
bruening

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

More Reviews

Description

Fix for drmemory failure on I411ToARGB Before I420ToARGB_Opt (594 ms) I422ToARGB_Opt (483 ms) I411ToARGB_Opt (748 ms) *** I444ToARGB_Opt (452 ms) I400ToARGB_Opt (218 ms) After I420ToARGB_Opt (591 ms) I422ToARGB_Opt (454 ms) I411ToARGB_Opt (502 ms) *** I444ToARGB_Opt (441 ms) I400ToARGB_Opt (216 ms) TBR=harryjin@google.com BUG=libyuv:525 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/5eefbe2330868cc7c913346e0a72111c93c245f9

Patch Set 1 #

Patch Set 2 : fix indent issues in unittest #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -90 lines)			Patch
M	README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	source/row_win.cc	View		2 chunks	+18 lines, -11 lines	0 comments	Download
M	unit_test/convert_test.cc	View	1	19 chunks	+67 lines, -77 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fbarchard

set GYP_DEFINES=build_for_tool=drmemory target_arch=ia32 python build\gyp_chromium -fninja -G msvs_version=2013 --depth=. libyuv_test.gyp ninja -C out\Release drmemory out\debug\libyuv_unittest.exe ...

5 years, 1 month ago (2015-11-17 23:35:35 UTC) #3

set GYP_DEFINES=build_for_tool=drmemory target_arch=ia32
python build\gyp_chromium -fninja -G msvs_version=2013 --depth=. libyuv_test.gyp
ninja -C out\Release
drmemory out\debug\libyuv_unittest.exe --gtest_catch_exceptions=0
--gtest_filter=*I411ToARGB_Opt


Before
Dr. Memory version 1.6.1 build 2 built on Dec 14 2013 12:27:10
Dr. Memory results for pid 10636: "libyuv_unittest.exe"
Application cmdline: "out\debug\libyuv_unittest.exe --gtest_catch_exceptions=0
--gtest_filter=*I411ToARGB_Opt"
Recorded 99 suppression(s) from default C:\Program Files (x86)\Dr.
Memory\bin\suppress-default.txt

Error #1: UNINITIALIZED READ: reading 0x00e28988-0x00e28989 1 byte(s) within
0x00e28985-0x00e28989
# 0 I411ToARGBRow_SSSE3                                                       
[c:\src\libyuv2\libyuv\source\row_win.cc:2829]
# 1 I411ToARGBRow_Any_SSSE3                                                   
[c:\src\libyuv2\libyuv\source\row_any.cc:120]
# 2 I411ToARGB                                                                
[c:\src\libyuv2\libyuv\source\convert_argb.cc:549]
# 3 libyuv::LibYUVConvertTest_I411ToARGB_Opt_Test::TestBody                   
[c:\src\libyuv2\libyuv\unit_test\convert_test.cc:510]
# 4 testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2458]
# 5 testing::Test::Run                                                        
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2475]
# 6 testing::TestInfo::Run                                                    
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2656]
# 7 testing::TestCase::Run                                                    
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2774]
# 8 testing::internal::UnitTestImpl::RunAllTests                              
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:4647]
# 9
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2458]
#10 testing::UnitTest::Run                                                    
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:4258]
#11 RUN_ALL_TESTS                                                             
[c:\src\libyuv2\libyuv\testing\gtest\include\gtest\gtest.h:2237]
Note: @0:00:03.784 in thread 1888
Note: instruction: pinsrw (%esi) $0x00 -> %xmm0

Error #2: UNINITIALIZED READ: reading 0x00e29348-0x00e29349 1 byte(s) within
0x00e29345-0x00e29349
# 0 I411ToARGBRow_SSSE3                                                       
[c:\src\libyuv2\libyuv\source\row_win.cc:2829]
# 1 I411ToARGBRow_Any_SSSE3                                                   
[c:\src\libyuv2\libyuv\source\row_any.cc:120]
# 2 I411ToARGB                                                                
[c:\src\libyuv2\libyuv\source\convert_argb.cc:549]
# 3 libyuv::LibYUVConvertTest_I411ToARGB_Opt_Test::TestBody                   
[c:\src\libyuv2\libyuv\unit_test\convert_test.cc:510]
# 4 testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void>
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2458]
# 5 testing::Test::Run                                                        
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2475]
# 6 testing::TestInfo::Run                                                    
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2656]
# 7 testing::TestCase::Run                                                    
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2774]
# 8 testing::internal::UnitTestImpl::RunAllTests                              
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:4647]
# 9
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool>
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:2458]
#10 testing::UnitTest::Run                                                    
[c:\src\libyuv2\libyuv\testing\gtest\src\gtest.cc:4258]
#11 RUN_ALL_TESTS                                                             
[c:\src\libyuv2\libyuv\testing\gtest\include\gtest\gtest.h:2237]
Note: @0:00:03.788 in thread 1888
Note: instruction: pinsrw (%esi,%edi,1) $0x00 -> %xmm1

===========================================================================
FINAL SUMMARY:

DUPLICATE ERROR COUNTS:

SUPPRESSIONS USED:

ERRORS FOUND:
      0 unique,     0 total unaddressable access(es)
      2 unique,     2 total uninitialized access(es)
      0 unique,     0 total invalid heap argument(s)
      0 unique,     0 total GDI usage error(s)
      0 unique,     0 total warning(s)
      0 unique,     0 total,      0 byte(s) of leak(s)
      0 unique,     0 total,      0 byte(s) of possible leak(s)
ERRORS IGNORED:
     10 potential leak(s) (suspected false positives)
         (details: C:\Users\fbarchard\AppData\Roaming\Dr.
Memory\DrMemory-libyuv_unittest.exe.10636.000\potential_errors.txt)
    123 unique,   193 total,  12426 byte(s) of still-reachable allocation(s)
         (re-run with "-show_reachable" for details)
Details: C:\Users\fbarchard\AppData\Roaming\Dr.
Memory\DrMemory-libyuv_unittest.exe.10636.000\results.txt


After:
Dr. Memory version 1.6.1 build 2 built on Dec 14 2013 12:27:10
Dr. Memory results for pid 8636: "libyuv_unittest.exe"
Application cmdline: "out\debug\libyuv_unittest.exe --gtest_catch_exceptions=0
--gtest_filter=*I411ToARGB_Opt"
Recorded 99 suppression(s) from default C:\Program Files (x86)\Dr.
Memory\bin\suppress-default.txt

===========================================================================
FINAL SUMMARY:

DUPLICATE ERROR COUNTS:

SUPPRESSIONS USED:

NO ERRORS FOUND:
      0 unique,     0 total unaddressable access(es)
      0 unique,     0 total uninitialized access(es)
      0 unique,     0 total invalid heap argument(s)
      0 unique,     0 total GDI usage error(s)
      0 unique,     0 total warning(s)
      0 unique,     0 total,      0 byte(s) of leak(s)
      0 unique,     0 total,      0 byte(s) of possible leak(s)
ERRORS IGNORED:
     10 potential leak(s) (suspected false positives)
         (details: C:\Users\fbarchard\AppData\Roaming\Dr.
Memory\DrMemory-libyuv_unittest.exe.8636.000\potential_errors.txt)
    123 unique,   196 total,  12495 byte(s) of still-reachable allocation(s)
         (re-run with "-show_reachable" for details)
Details: C:\Users\fbarchard\AppData\Roaming\Dr.
Memory\DrMemory-libyuv_unittest.exe.8636.000\results.txt

fbarchard1

5 years, 1 month ago (2015-11-18 02:00:57 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5eefbe2330868cc7c913346e0a72111c93c245f9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages