Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: tests/standalone/io/http_auth_digest_test.dart

Issue 14595008: Fix digest authentication to use the correct URI (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_auth_digest_test.dart
diff --git a/tests/standalone/io/http_auth_digest_test.dart b/tests/standalone/io/http_auth_digest_test.dart
index 720ed148e5c2646b84f58a9d9711401397409e58..74e9d93835770a425a7662e8bb95f716dd4d00de 100644
--- a/tests/standalone/io/http_auth_digest_test.dart
+++ b/tests/standalone/io/http_auth_digest_test.dart
@@ -83,7 +83,7 @@ class Server {
Expect.equals(realm, header.parameters["realm"]);
Expect.equals("MD5", header.parameters["algorithm"]);
Expect.equals(nonce, header.parameters["nonce"]);
- Expect.equals(request.uri.path, uri);
+ Expect.equals(request.uri.toString(), uri);
if (qop != null) {
// A server qop of auth-int is downgraded to none by the client.
Expect.equals("auth", serverQop);
@@ -201,10 +201,17 @@ void testCredentials(String algorithm, String qop) {
new HttpClientDigestCredentials("dart", "password"));
var futures = [];
- for (int i = 0; i < 5; i++) {
+ for (int i = 0; i < 2; i++) {
+ String uriBase = "http://127.0.0.1:${server.port}/digest";
futures.add(
makeRequest(
- Uri.parse("http://127.0.0.1:${server.port}/digest")));
+ Uri.parse(uriBase)));
+ futures.add(
+ makeRequest(
+ Uri.parse("$uriBase?querystring")));
+ futures.add(
+ makeRequest(
+ Uri.parse("$uriBase?querystring#fragment")));
}
Future.wait(futures).then((_) {
server.shutdown();
« no previous file with comments | « sdk/lib/io/http_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698