Remove ScopedVector from memory_dump_manager_unittest

Remove ScopedVector from memory_dump_manager_unittest

BUG=554289
sdf

Committed: https://crrev.com/689e957c5b5f71c0437cf013e8edb3307240f781
Cr-Commit-Position: refs/heads/master@{#361987}

[Olli Raula, 2015-11-19 16:41:30]

Description was changed from

==========
Remove ScopedVector from memory_dump_manager_unittest

BUG=554289

sdf
==========

to

==========
Remove ScopedVector from memory_dump_manager_unittest

BUG=554289

sdf
==========

[Olli Raula, 2015-11-19 16:41:30]

olli.raula@intel.com changed reviewers:
+ nduca@chromium.org

[Olli Raula, 2015-11-19 16:41:43]

Could you review?

[Primiano Tucci (use gerrit), 2015-11-19 23:16:48]

On 2015/11/19 16:41:43, Olli Raula wrote:
> Could you review?

I can review these, I'm just OOO until tuesday.
I assume there is no urgency, can we wait until then?
(Thanks for the cleanup)

[Primiano Tucci (use gerrit), 2015-11-24 10:38:10]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-11-24 10:38:10]

I can take these reviews, just back from vacation.
I'm asking for clarifications on cxx@chromium.org, still not clear whether we
can use c++11 lib features in base/

See discussion in
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/gKRtFBugpeA

[Olli Raula, 2015-11-26 12:00:44]

On 2015/11/24 10:38:10, Primiano Tucci wrote:
> I can take these reviews, just back from vacation.
> I'm asking for clarifications on mailto:cxx@chromium.org, still not clear
whether we
> can use c++11 lib features in base/
> 
> See discussion in
> https://groups.google.com/a/chromium.org/forum/#!topic/cxx/gKRtFBugpeA

End this?

[Primiano Tucci (use gerrit), 2015-11-26 15:38:02]

https://codereview.chromium.org/1459473006/diff/1/base/trace_event/memory_dum...
File base/trace_event/memory_dump_manager_unittest.cc (right):

https://codereview.chromium.org/1459473006/diff/1/base/trace_event/memory_dum...
base/trace_event/memory_dump_manager_unittest.cc:380:
threads.push_back(make_scoped_ptr(new Thread("test thread")));
I honestly did prefer keeping these as separate lines, as it is more redable.
I'd do:
threads.push_back(make_scoped_ptr(new Thread("test thread")));
auto thread = threads.back().get()
leave below unchanged

ditto below for mdp

[Olli Raula, 2015-11-27 11:55:10]

Fixed!

[Primiano Tucci (use gerrit), 2015-11-27 12:44:11]

LGTM thanks for all the cleanups

[Olli Raula, 2015-11-27 12:48:52]

The CQ bit was checked by olli.raula@intel.com

[commit-bot: I haz the power, 2015-11-27 12:49:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459473006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459473006/20001

[commit-bot: I haz the power, 2015-11-27 12:53:43]

Description was changed from

==========
Remove ScopedVector from memory_dump_manager_unittest

BUG=554289

sdf
==========

to

==========
Remove ScopedVector from memory_dump_manager_unittest

BUG=554289

sdf
==========

[commit-bot: I haz the power, 2015-11-27 12:53:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-27 12:54:32]

Description was changed from

==========
Remove ScopedVector from memory_dump_manager_unittest

BUG=554289

sdf
==========

to

==========
Remove ScopedVector from memory_dump_manager_unittest

BUG=554289

sdf

Committed: https://crrev.com/689e957c5b5f71c0437cf013e8edb3307240f781
Cr-Commit-Position: refs/heads/master@{#361987}
==========

[commit-bot: I haz the power, 2015-11-27 12:54:33]

Patchset 2 (id:??) landed as
https://crrev.com/689e957c5b5f71c0437cf013e8edb3307240f781
Cr-Commit-Position: refs/heads/master@{#361987}