Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: third_party/WebKit/Source/core/frame/LocalFrame.h

Issue 1459473005: [Oilpan] Replace raw pointer with UntracedMember (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 // of in the process. This is needed as the plugin element 235 // of in the process. This is needed as the plugin element
236 // might not itself be attached to a DOM tree and be 236 // might not itself be attached to a DOM tree and be
237 // explicitly detached&disposed of. 237 // explicitly detached&disposed of.
238 // 238 //
239 // A weak reference is all wanted; the plugin element must 239 // A weak reference is all wanted; the plugin element must
240 // otherwise be referenced and kept alive. So as to be able 240 // otherwise be referenced and kept alive. So as to be able
241 // to process the set of weak references during the LocalFrame's 241 // to process the set of weak references during the LocalFrame's
242 // weak callback, the set itself is not on the heap and the 242 // weak callback, the set itself is not on the heap and the
243 // references are bare pointers (rather than WeakMembers.) 243 // references are bare pointers (rather than WeakMembers.)
244 // See LocalFrame::clearWeakMembers(). 244 // See LocalFrame::clearWeakMembers().
245 GC_PLUGIN_IGNORE("553613") 245 HashSet<UntracedMember<HTMLPlugInElement>> m_pluginElements;
246 HashSet<HTMLPlugInElement*> m_pluginElements;
247 #endif 246 #endif
248 247
249 float m_pageZoomFactor; 248 float m_pageZoomFactor;
250 float m_textZoomFactor; 249 float m_textZoomFactor;
251 250
252 bool m_inViewSourceMode; 251 bool m_inViewSourceMode;
253 252
254 RefPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents; 253 RefPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents;
255 254
256 // TODO(dcheng): Temporary to try to debug https://crbug.com/531291 255 // TODO(dcheng): Temporary to try to debug https://crbug.com/531291
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 }; 345 };
347 346
348 } // namespace blink 347 } // namespace blink
349 348
350 // During refactoring, there are some places where we need to do type conversion s that 349 // During refactoring, there are some places where we need to do type conversion s that
351 // will not be needed once all instances of LocalFrame and RemoteFrame are sorte d out. 350 // will not be needed once all instances of LocalFrame and RemoteFrame are sorte d out.
352 // At that time this #define will be removed and all the uses of it will need to be corrected. 351 // At that time this #define will be removed and all the uses of it will need to be corrected.
353 #define toLocalFrameTemporary toLocalFrame 352 #define toLocalFrameTemporary toLocalFrame
354 353
355 #endif // LocalFrame_h 354 #endif // LocalFrame_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698