Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 1459473003: Add a WebContents getter callback in ResourceRequestInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed David's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 2c243784c8138d3d5b4b3c2d932453be0613c9f2..0b88116b1f19e2bb89666f80de718b3348844c70 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -356,8 +356,7 @@ AwContentBrowserClient::CreateQuotaPermissionContext() {
}
void AwContentBrowserClient::AllowCertificateError(
- int render_process_id,
- int render_frame_id,
+ content::WebContents* web_contents,
int cert_error,
const net::SSLInfo& ssl_info,
const GURL& request_url,
@@ -368,7 +367,7 @@ void AwContentBrowserClient::AllowCertificateError(
const base::Callback<void(bool)>& callback,
content::CertificateRequestResultType* result) {
AwContentsClientBridgeBase* client =
- AwContentsClientBridgeBase::FromID(render_process_id, render_frame_id);
+ AwContentsClientBridgeBase::FromWebContents(web_contents);
mnaganov (inactive) 2015/11/23 16:47:42 Thanks! Looks like we can now remove AwContentsCli
bool cancel_request = true;
if (client)
client->AllowCertificateError(cert_error,

Powered by Google App Engine
This is Rietveld 408576698