android_webview/browser/aw_content_browser_client.cc - Issue 1459473003: Add a WebContents getter callback in ResourceRequestInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 1459473003: Add a WebContents getter callback in ResourceRequestInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed davidben's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | content/browser/loader/resource_request_info_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_content_browser_client.cc

diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc

index 2c243784c8138d3d5b4b3c2d932453be0613c9f2..0b88116b1f19e2bb89666f80de718b3348844c70 100644

--- a/android_webview/browser/aw_content_browser_client.cc

+++ b/android_webview/browser/aw_content_browser_client.cc

@@ -356,8 +356,7 @@ AwContentBrowserClient::CreateQuotaPermissionContext() {

}

void AwContentBrowserClient::AllowCertificateError(

- int render_process_id,

- int render_frame_id,

+ content::WebContents* web_contents,

int cert_error,

const net::SSLInfo& ssl_info,

const GURL& request_url,

@@ -368,7 +367,7 @@ void AwContentBrowserClient::AllowCertificateError(

const base::Callback<void(bool)>& callback,

content::CertificateRequestResultType* result) {

AwContentsClientBridgeBase* client =

- AwContentsClientBridgeBase::FromID(render_process_id, render_frame_id);

+ AwContentsClientBridgeBase::FromWebContents(web_contents);

bool cancel_request = true;

if (client)

client->AllowCertificateError(cert_error,