Add a WebContents getter callback in ResourceRequestInfo

content/browser/ssl/ssl_policy.cc

Index: content/browser/ssl/ssl_policy.cc
diff --git a/content/browser/ssl/ssl_policy.cc b/content/browser/ssl/ssl_policy.cc
index dab2a5aa1ecd98f5627175d19dc0cfa6fe705301..bd33a5574534b9abaab5a4cee48083fdfc0f1b70 100644
--- a/content/browser/ssl/ssl_policy.cc
+++ b/content/browser/ssl/ssl_policy.cc
@@ -232,8 +232,7 @@ void SSLPolicy::OnCertErrorInternal(SSLCertErrorHandler* handler,
   CertificateRequestResultType result =
       CERTIFICATE_REQUEST_RESULT_TYPE_CONTINUE;
   GetContentClient()->browser()->AllowCertificateError(
-      handler->render_process_id(),
-      handler->render_frame_id(),
+      handler->web_contents_getter(),

[davidben, 2015/11/19 17:46:13]

Wow, this code is all kinds of silly. This gets called from
SSLPolicy::OnCertError, which gets called from
SSLCertErrorHandler::OnDispatched... which is calling something off of
manager_... which is a per-WebContents object that has a pointer back to the
WebContents through the NavigationControllerImpl!

Not going to ask you to refactor it all here, but probably you can get the
WebContents itself without having to go through the callback.

[davidben, 2015/11/19 17:50:25]

Oh! And even SSLPolicy is a per-WebContents object! Though it doesn't have a
pointer back up. Yeah, this is all totally silly. I'm not sure why there is an
SSLPolicy / SSLManager split, TBH.

[clamy, 2015/11/20 13:50:43]

Done. I now expose the manager from the handler, and we can get the WebContents
through the NavigationController.

       handler->cert_error(),
       handler->ssl_info(),
       handler->request_url(),