Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: content/browser/ssl/ssl_error_handler.cc

Issue 1459473003: Add a WebContents getter callback in ResourceRequestInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Nasko's comment Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/ssl/ssl_error_handler.h ('k') | content/browser/ssl/ssl_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/ssl/ssl_error_handler.cc
diff --git a/content/browser/ssl/ssl_error_handler.cc b/content/browser/ssl/ssl_error_handler.cc
index 45b6dfd830ce6a3ab66d3c582812ddd418e0f226..40b2b564506286c92013d699305ea6652399ac86 100644
--- a/content/browser/ssl/ssl_error_handler.cc
+++ b/content/browser/ssl/ssl_error_handler.cc
@@ -20,13 +20,9 @@ namespace content {
SSLErrorHandler::SSLErrorHandler(const base::WeakPtr<Delegate>& delegate,
ResourceType resource_type,
- const GURL& url,
- int render_process_id,
- int render_frame_id)
+ const GURL& url)
: manager_(NULL),
delegate_(delegate),
- render_process_id_(render_process_id),
- render_frame_id_(render_frame_id),
request_url_(url),
resource_type_(resource_type),
request_has_been_notified_(false) {
@@ -55,13 +51,11 @@ SSLCertErrorHandler* SSLErrorHandler::AsSSLCertErrorHandler() {
return NULL;
}
-void SSLErrorHandler::Dispatch() {
+void SSLErrorHandler::Dispatch(
+ const base::Callback<WebContents*(void)>& web_contents_getter) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- WebContents* web_contents = NULL;
- RenderFrameHost* render_frame_host =
- RenderFrameHost::FromID(render_process_id_, render_frame_id_);
- web_contents = WebContents::FromRenderFrameHost(render_frame_host);
+ WebContents* web_contents = web_contents_getter.Run();
if (!web_contents) {
// We arrived on the UI thread, but the tab we're looking for is no longer
@@ -116,6 +110,11 @@ void SSLErrorHandler::TakeNoAction() {
base::Bind(&SSLErrorHandler::CompleteTakeNoAction, this));
}
+SSLManager* SSLErrorHandler::GetManager() const {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+ return manager_;
+}
+
void SSLErrorHandler::CompleteCancelRequest(int error) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
« no previous file with comments | « content/browser/ssl/ssl_error_handler.h ('k') | content/browser/ssl/ssl_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698