Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1459393002: Fix inconsistencies in CHROMIUM_sync_point.txt. (Closed)

Created:
5 years, 1 month ago by vmiura
Modified:
5 years, 1 month ago
Reviewers:
David Yen
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inconsistencies in CHROMIUM_sync_point.txt. TBR=piman@chromium.org BUG= Committed: https://crrev.com/8ce802a95cf8849be3c02f65b17be17720d6d7a8 Cr-Commit-Position: refs/heads/master@{#360962}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix other inconsistencies. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
vmiura
ptal
5 years, 1 month ago (2015-11-20 02:08:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459393002/1
5 years, 1 month ago (2015-11-20 02:11:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-20 04:10:17 UTC) #6
David Yen
LGTM but can you fix these 4 spots as well? https://codereview.chromium.org/1459393002/diff/1/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt (right): https://codereview.chromium.org/1459393002/diff/1/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt#newcode89 ...
5 years, 1 month ago (2015-11-20 17:51:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459393002/20001
5 years, 1 month ago (2015-11-20 23:43:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-21 00:37:06 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 00:37:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ce802a95cf8849be3c02f65b17be17720d6d7a8
Cr-Commit-Position: refs/heads/master@{#360962}

Powered by Google App Engine
This is Rietveld 408576698