Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1459373003: Mark HiddenValue API as deprecated (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark HiddenValue API as deprecated BUG=none R=vogelheim@chromium.org Committed: https://crrev.com/3c2bec8d70092ea8f9ec134bbd07630fc049fa8b Cr-Commit-Position: refs/heads/master@{#32340}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M include/v8.h View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-11-20 07:36:43 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459373003/1
5 years, 1 month ago (2015-11-20 09:42:08 UTC) #3
vogelheim
lgtm
5 years, 1 month ago (2015-11-20 10:02:20 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/10296)
5 years, 1 month ago (2015-11-20 10:02:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459373003/1
5 years ago (2015-11-25 09:56:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459373003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459373003/20001
5 years ago (2015-11-26 13:42:13 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 14:19:31 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-26 14:19:59 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c2bec8d70092ea8f9ec134bbd07630fc049fa8b
Cr-Commit-Position: refs/heads/master@{#32340}

Powered by Google App Engine
This is Rietveld 408576698