third_party/WebKit/Source/core/paint/GridPainter.cpp - Issue 1459373002: [css-grid] Refactor GridSpan to avoid pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/GridPainter.cpp

Issue 1459373002: [css-grid] Refactor GridSpan to avoid pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/GridPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/GridPainter.cpp b/third_party/WebKit/Source/core/paint/GridPainter.cpp

index c029941c40bb600a8afc5a8d9f1c71ea113e1a18..3fa13c81fed09305ca1f14ead3b79e3bff06916f 100644

--- a/third_party/WebKit/Source/core/paint/GridPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/GridPainter.cpp

@@ -25,7 +25,7 @@ static GridSpan dirtiedGridAreas(const Vector<LayoutUnit>& coordinates, LayoutUn

--endGridAreaIndex;

// GridSpan stores lines' indexes (not tracks' indexes).

- return GridSpan(startGridAreaIndex, endGridAreaIndex + 1);

+ return GridSpan::definiteGridSpan(startGridAreaIndex, endGridAreaIndex + 1);

}

class GridItemsSorter {