Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1459343009: Make QuicPacketCreator be able to serialize packet itself when it does not have room for next strea… (Closed)

Created:
5 years, 1 month ago by ianswett
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@107733506
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QuicPacketCreator be able to serialize packet itself when it does not have room for next stream frame. No functional change expected. For QuicPacketCreator, add DelegateInterface class, Flush function, move SerializePacket from public to private. For QuicPacketGenerator, add OnSerializedPacket function, remove SerializeAndSendPacket. Merge internal change: 107814957 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -207 lines) Patch
M net/quic/quic_connection_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator.h View 10 chunks +40 lines, -20 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 4 chunks +30 lines, -6 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 28 chunks +163 lines, -122 lines 0 comments Download
M net/quic/quic_packet_generator.h View 4 chunks +9 lines, -4 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 8 chunks +41 lines, -52 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_bin.cc View 1 chunk +12 lines, -0 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
ianswett
5 years, 1 month ago (2015-11-21 22:53:12 UTC) #1
Ryan Hamilton
https://codereview.chromium.org/1459343009/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1459343009/diff/1/net/tools/quic/quic_server_bin.cc#newcode73 net/tools/quic/quic_server_bin.cc:73: >>>>>>> I think something has gone sideways...
5 years, 1 month ago (2015-11-22 00:55:32 UTC) #2
ianswett
quic_server_bin.cc fixed in Final. https://codereview.chromium.org/1459343009/diff/1/net/tools/quic/quic_server_bin.cc File net/tools/quic/quic_server_bin.cc (right): https://codereview.chromium.org/1459343009/diff/1/net/tools/quic/quic_server_bin.cc#newcode73 net/tools/quic/quic_server_bin.cc:73: >>>>>>> On 2015/11/22 00:55:32, Ryan ...
5 years ago (2015-11-23 20:05:19 UTC) #3
Ryan Hamilton
lgtm
5 years ago (2015-11-23 20:53:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459343009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459343009/1
5 years ago (2015-11-24 04:06:08 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 04:10:43 UTC) #8
Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698