Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1459333002: Revert "Reland: URLRequestJob: change ReadRawData contract" (Closed)

Created:
5 years, 1 month ago by xunjieli
Modified:
5 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, tzik, yzshen+watch_chromium.org, kinuko+watch, ben+mojo_chromium.org, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, android-webview-reviews_chromium.org, blink-worker-reviews_chromium.org, nhiroki, oshima+watch_chromium.org, zork+watch_chromium.org, michaeln, serviceworker-reviews, Aaron Boodman, kinuko+serviceworker, Paweł Hajdan Jr., horo+watch_chromium.org, darin (slow to review), kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Reland: URLRequestJob: change ReadRawData contract" This reverts commit d77911ac82186d65a8f11555a7a6b1678c769ba2. The previous CL caused a top crasher on Canary. Reverting this CL now since fixing the crash isn't straightforward. TBR=michaeln@chromium.org,mnaganov@chromium.org,skyostil@chromium.org,eugenebut@chromium.org,davidben@chromium.org,falken@chromium.org,mtomasz@chromium.org, sky@chromium.org,jianli@chromium.org,zork@chromium.org,mmenke@chromium.org,rdsmith@chromium.org BUG=558224 BUG=553300 BUG=474859 BUG=329902 Committed: https://crrev.com/aacaaa7fef4ee77110471c1a8e02e6c262d0a0a3 Cr-Commit-Position: refs/heads/master@{#360809}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+925 lines, -825 lines) Patch
M android_webview/browser/net/android_stream_reader_url_request_job.h View 3 chunks +1 line, -3 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.cc View 8 chunks +38 lines, -28 lines 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job.cc View 6 chunks +33 lines, -31 lines 0 comments Download
M content/browser/android/url_request_content_job.h View 4 chunks +2 lines, -4 lines 0 comments Download
M content/browser/android/url_request_content_job.cc View 7 chunks +48 lines, -33 lines 0 comments Download
M content/browser/appcache/appcache_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_url_request_job.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/net/view_http_cache_job_factory.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_read_from_cache_job.cc View 5 chunks +33 lines, -38 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 6 chunks +47 lines, -29 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.h View 4 chunks +13 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 15 chunks +110 lines, -95 lines 0 comments Download
M content/browser/streams/stream_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/streams/stream_url_request_job.cc View 5 chunks +37 lines, -26 lines 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 5 chunks +24 lines, -13 lines 0 comments Download
M content/test/net/url_request_abort_on_end_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/net/url_request_abort_on_end_job.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.cc View 3 chunks +24 lines, -12 lines 0 comments Download
M mojo/services/network/url_loader_impl_apptest.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M net/test/url_request/url_request_failed_job.h View 2 chunks +1 line, -2 lines 0 comments Download
M net/test/url_request/url_request_failed_job.cc View 2 chunks +29 lines, -22 lines 0 comments Download
M net/test/url_request/url_request_mock_data_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/test/url_request/url_request_mock_data_job.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M net/test/url_request/url_request_slow_download_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/test/url_request/url_request_slow_download_job.cc View 2 chunks +17 lines, -10 lines 0 comments Download
M net/url_request/url_request_file_dir_job.h View 4 chunks +2 lines, -4 lines 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 3 chunks +28 lines, -27 lines 0 comments Download
M net/url_request/url_request_file_job.h View 3 chunks +1 line, -5 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 10 chunks +37 lines, -24 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_ftp_job.cc View 4 chunks +25 lines, -6 lines 0 comments Download
M net/url_request/url_request_http_job.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 4 chunks +31 lines, -12 lines 0 comments Download
M net/url_request/url_request_job.h View 7 chunks +40 lines, -53 lines 0 comments Download
M net/url_request/url_request_job.cc View 16 chunks +99 lines, -132 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 2 chunks +0 lines, -44 lines 0 comments Download
M net/url_request/url_request_simple_job.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_simple_job.cc View 3 chunks +24 lines, -11 lines 0 comments Download
M net/url_request/url_request_status.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/url_request/url_request_status.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M net/url_request/url_request_test_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_test_job.cc View 4 chunks +19 lines, -11 lines 0 comments Download
M storage/browser/blob/blob_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/blob/blob_url_request_job.cc View 3 chunks +28 lines, -14 lines 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.cc View 6 chunks +13 lines, -8 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.h View 4 chunks +2 lines, -3 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.cc View 10 chunks +39 lines, -31 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459333002/1
5 years, 1 month ago (2015-11-19 20:56:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459333002/1
5 years, 1 month ago (2015-11-19 22:08:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-19 22:59:10 UTC) #12
xunjieli
5 years, 1 month ago (2015-11-19 23:15:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459333002/1
5 years, 1 month ago (2015-11-19 23:16:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-20 01:22:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459333002/1
5 years, 1 month ago (2015-11-20 01:53:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459333002/1
5 years, 1 month ago (2015-11-20 13:33:26 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 13:39:38 UTC) #23
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 13:40:39 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aacaaa7fef4ee77110471c1a8e02e6c262d0a0a3
Cr-Commit-Position: refs/heads/master@{#360809}

Powered by Google App Engine
This is Rietveld 408576698