Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1362)

Unified Diff: content/public/browser/download_manager.h

Issue 14593012: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index e34f0803731b65c9a0d785c5068e7f4c32884315..e6918523dd636fb1d93092aac43bbf9f71d7e9a3 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -56,9 +56,10 @@ struct DownloadCreateInfo;
struct DownloadRetrieveInfo;
// Browser's download manager: manages all downloads and destination view.
-class CONTENT_EXPORT DownloadManager
- : public base::RefCountedThreadSafe<DownloadManager> {
+class CONTENT_EXPORT DownloadManager : public base::SupportsUserData::Data {
public:
+ virtual ~DownloadManager() {}
+
// Sets/Gets the delegate for this DownloadManager. The delegate has to live
// past its Shutdown method being called (by the DownloadManager).
virtual void SetDelegate(DownloadManagerDelegate* delegate) = 0;
@@ -169,12 +170,6 @@ class CONTENT_EXPORT DownloadManager
// Get the download item for |id| if present, no matter what type of download
// it is or state it's in.
virtual DownloadItem* GetDownload(int id) = 0;
-
- protected:
- virtual ~DownloadManager() {}
-
- private:
- friend class base::RefCountedThreadSafe<DownloadManager>;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698