content/browser/download/download_manager_impl.cc - Issue 14593012: BrowserContext should simply own DownloadManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_manager_impl.cc

Issue 14593012: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_manager_impl.cc

diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc

index 5dc5aa17b59f3220bc75a47090b8335bd226c7f9..f23f286b631f9ff2665d042e9ca62d5dd0cf1c85 100644

--- a/content/browser/download/download_manager_impl.cc

+++ b/content/browser/download/download_manager_impl.cc

@@ -239,7 +239,8 @@ DownloadManagerImpl::DownloadManagerImpl(

shutdown_needed_(true),

browser_context_(browser_context),

delegate_(NULL),

- net_log_(net_log) {

+ net_log_(net_log),

+ weak_factory_(this) {

DCHECK(browser_context);

}

@@ -447,7 +448,7 @@ void DownloadManagerImpl::CheckForFileRemoval(DownloadItemImpl* download_item) {

delegate_->CheckForFileExistence(

download_item,

base::Bind(&DownloadManagerImpl::OnFileExistenceChecked,

- this, download_item->GetId()));

+ weak_factory_.GetWeakPtr(), download_item->GetId()));

}