Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/browser/plugins/plugin_installer.cc

Issue 14593012: BrowserContext should simply own DownloadManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_installer.cc
diff --git a/chrome/browser/plugins/plugin_installer.cc b/chrome/browser/plugins/plugin_installer.cc
index bac5705594da229e40172b564db5b9efae94e75c..f40caa3320d3313993b44e97cd6980cbd9d22b36 100644
--- a/chrome/browser/plugins/plugin_installer.cc
+++ b/chrome/browser/plugins/plugin_installer.cc
@@ -136,8 +136,6 @@ void PluginInstaller::StartInstalling(const GURL& plugin_url,
FOR_EACH_OBSERVER(PluginInstallerObserver, observers_, DownloadStarted());
Profile* profile =
Profile::FromBrowserContext(web_contents->GetBrowserContext());
- DownloadManager* download_manager =
- BrowserContext::GetDownloadManager(profile);
download_util::RecordDownloadSource(
download_util::INITIATED_BY_PLUGIN_INSTALLER);
BrowserThread::PostTask(
@@ -148,12 +146,10 @@ void PluginInstaller::StartInstalling(const GURL& plugin_url,
web_contents->GetRenderProcessHost()->GetID(),
web_contents->GetRenderViewHost()->GetRoutingID(),
base::Bind(&PluginInstaller::DownloadStarted,
- base::Unretained(this),
- make_scoped_refptr(download_manager))));
+ base::Unretained(this))));
}
void PluginInstaller::DownloadStarted(
- scoped_refptr<content::DownloadManager> dlm,
content::DownloadItem* item,
net::Error error) {
if (!item) {

Powered by Google App Engine
This is Rietveld 408576698