BrowserContext should simply own DownloadManager

chrome/browser/download/test_download_shelf.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/test_download_shelf.h"
 
 #include "content/public/browser/download_manager.h"
 
 TestDownloadShelf::TestDownloadShelf()
     : is_showing_(false),
@@ skipping 10 matching lines @@
 bool TestDownloadShelf::IsClosing() const {
   return false;
 }
 
 Browser* TestDownloadShelf::browser() const {
   return NULL;
 }
 
 void TestDownloadShelf::set_download_manager(
     content::DownloadManager* download_manager) {
   download_manager_ = download_manager;

[benjhayden, 2013/05/17 14:50:03]

Should TestDownloadShelf observe download_manager_ and NULLify it when
ManagerGoingDown()?

[cmarcelo, 2013/05/20 15:22:06]

It's not strictly necessary for the existing code using it because in the only
test where the download manager is set the lifetime of downloadmanager is larger
than the shelf.

However I think is good that it does observe. I will update this.

 }
 
 void TestDownloadShelf::DoAddDownload(content::DownloadItem* download) {
   did_add_download_ = true;
 }
 
 void TestDownloadShelf::DoShow() {
   is_showing_ = true;
 }
 
 void TestDownloadShelf::DoClose(CloseReason reason) {
   is_showing_ = false;
 }
 
 base::TimeDelta TestDownloadShelf::GetTransientDownloadShowDelay() {
   return base::TimeDelta();
 }
 
 content::DownloadManager* TestDownloadShelf::GetDownloadManager() {
-  return download_manager_.get();
+  return download_manager_;
 }