Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1459273002: dart2js load elimination: Look through refinements for locations (Closed)

Created:
5 years, 1 month ago by sra1
Modified:
4 years, 3 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js load elimination: Look through refinements for locations We have to look through the refinements (via .nonCheck()) for locations in order to avoid mistaking two different refinements for two separate locations. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/3d9bbdaa9a158f39f46564562616128cff9327a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -18 lines) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 7 chunks +44 lines, -18 lines 0 comments Download
A tests/compiler/dart2js_native/load_elim_refinement_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
sra1
Fixes a rare codegen bug.
4 years, 3 months ago (2016-09-20 04:34:50 UTC) #8
Harry Terkelsen
lgtm
4 years, 3 months ago (2016-09-20 19:23:04 UTC) #9
sra1
4 years, 3 months ago (2016-09-20 23:13:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:100001) manually as
3d9bbdaa9a158f39f46564562616128cff9327a1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698