Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1459263002: Reset the list of sequence switch key codes when switching key maps. (Closed)

Created:
5 years, 1 month ago by David Tseng
Modified:
5 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset the list of sequence switch key codes when switching key maps. Issue: - press Search+Shift+Q+Q (to switch to Next). - press Search+Q (to switch to Classic) - press Search+Shift+Q+Q (to again switch to Next) - press another key like right arrow. result: toogleChormeVoxVersion gets issued again and you get flipped back to classic. cvox.ChromeVox.sequenceSwitchCodes contains a lot of stale information; most importantly, it now considers Cvox+Q a sequence when it isn't one in Next. TEST=Verify the above is fixed. Committed: https://crrev.com/baef6824e2ea719979aa9db98c87b041f2875a2f Cr-Commit-Position: refs/heads/master@{#360644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
David Tseng
5 years, 1 month ago (2015-11-19 18:27:33 UTC) #3
dmazzoni
lgtm
5 years, 1 month ago (2015-11-19 18:41:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459263002/1
5 years, 1 month ago (2015-11-19 18:41:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 19:46:29 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 19:47:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/baef6824e2ea719979aa9db98c87b041f2875a2f
Cr-Commit-Position: refs/heads/master@{#360644}

Powered by Google App Engine
This is Rietveld 408576698