Issue 1459253002: Fix missing case for JS_PROMISE_TYPE for header size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1459253002: Fix missing case for JS_PROMISE_TYPE for header size. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger

Modified:
5 years, 1 month ago

Reviewers:
Toon Verwaest

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix missing case for JS_PROMISE_TYPE for header size. TBR=verwaest@chromium.org NOTREECHECKS=true Committed: https://crrev.com/58686b97e0ac4f6ab0c9d1757ec3c412edb38cb6 Cr-Commit-Position: refs/heads/master@{#32122}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/objects-inl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459253002/1

5 years, 1 month ago (2015-11-19 18:11:36 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/58686b97e0ac4f6ab0c9d1757ec3c412edb38cb6 Cr-Commit-Position: refs/heads/master@{#32122}

5 years, 1 month ago (2015-11-19 18:41:51 UTC) #5

Message was sent while issue was closed.

Lgtm, awesome, thanks for fixing!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages