Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1459243002: Remove CFX_Matrix::Reset() (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CFX_Matrix::Reset() It's unused on master, and on XFA, directly calling SetIdentity() is clearer to the reader anyways. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M core/include/fxcrt/fx_coordinates.h View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, quick review.
5 years, 1 month ago (2015-11-19 17:25:23 UTC) #2
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-19 22:33:09 UTC) #3
Tom Sepez
5 years, 1 month ago (2015-11-19 23:41:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698