Issue 1459243002: Remove CFX_Matrix::Reset()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1459243002: Remove CFX_Matrix::Reset() (Closed)

Created:
5 years, 1 month ago by Tom Sepez

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove CFX_Matrix::Reset() It's unused on master, and on XFA, directly calling SetIdentity() is clearer to the reader anyways. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	core/include/fxcrt/fx_coordinates.h	View		2 chunks	+1 line, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 1 month ago (2015-11-19 23:41:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806 (presubmit successful).