tools/telemetry/telemetry/core/timeline/thread.py - Issue 145923002: Added support to listen on Network.responseReceived and expose that through tab.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/timeline/thread.py

Issue 145923002: Added support to listen on Network.responseReceived and expose that through tab.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (inspector_network cleanup from previous API) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/core/timeline/model.py ('K') | « tools/telemetry/telemetry/core/timeline/recording_options.py ('k') | tools/telemetry/telemetry/core/web_contents.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/timeline/thread.py

diff --git a/tools/telemetry/telemetry/core/timeline/thread.py b/tools/telemetry/telemetry/core/timeline/thread.py

index fe667bdb0ae763f32259c6b0d7f7f65c11c92225..70e0c09628d0aad7cb5fc23069f2eb602794bd0e 100644

--- a/tools/telemetry/telemetry/core/timeline/thread.py

+++ b/tools/telemetry/telemetry/core/timeline/thread.py

@@ -224,7 +224,6 @@ class Thread(event_container.TimelineEventContainer):

return cmp(s2.end, s1.end)

return cmp(s1.start, s2.start)

- assert len(self._toplevel_slices) == 0

tonyg 2014/03/04 05:27:31 Can you explain this?

bolian 2014/03/04 20:32:44 After moving model out of timeline recorder, I don

if not len(self._newly_added_slices):

return