Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 1459223002: [iOS] Disable configuration_policy for iOS builds. (Closed)

Created:
5 years, 1 month ago by droger
Modified:
5 years ago
Reviewers:
Nico, sdefresne
CC:
bzanotti, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Disable configuration_policy for iOS builds. Policy is no longer used on iOS, this is dead code cleanup. BUG=550401 Committed: https://crrev.com/3e5bdb1f6e6644eb6da1864e66ecc2eab790e479 Cr-Commit-Position: refs/heads/master@{#361313}

Patch Set 1 #

Patch Set 2 : Update comment in features.gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/features.gni View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
droger
sdefresne: for review. Is there anything to do for GN? bzanotti: FYI
5 years, 1 month ago (2015-11-19 15:59:03 UTC) #2
sdefresne
On 2015/11/19 at 15:59:04, droger wrote: > sdefresne: for review. Is there anything to do ...
5 years, 1 month ago (2015-11-19 16:01:18 UTC) #3
droger
Done. I launched the bots, and it seems to be compiling (the failures look unrelated).
5 years, 1 month ago (2015-11-19 17:59:47 UTC) #4
sdefresne
lgtm
5 years, 1 month ago (2015-11-19 18:04:15 UTC) #5
droger
+thakis as OWNER
5 years, 1 month ago (2015-11-19 18:05:29 UTC) #7
droger
thakis: ping
5 years, 1 month ago (2015-11-23 08:56:50 UTC) #8
Nico
lgtm, but please always answer "why?" in the CL description (maybe via a bug link, ...
5 years, 1 month ago (2015-11-23 17:28:21 UTC) #9
sdefresne
Added link to RBS bug explaining the change.
5 years, 1 month ago (2015-11-23 17:32:50 UTC) #11
droger
Thanks for the review.
5 years ago (2015-11-24 09:11:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459223002/20001
5 years ago (2015-11-24 09:12:30 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 11:05:30 UTC) #16
commit-bot: I haz the power
5 years ago (2015-11-24 11:06:28 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e5bdb1f6e6644eb6da1864e66ecc2eab790e479
Cr-Commit-Position: refs/heads/master@{#361313}

Powered by Google App Engine
This is Rietveld 408576698