Issue 14592004: Merge 199135 "Fix mismatched parameter expectations between chro..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14592004: Merge 199135 "Fix mismatched parameter expectations between chro..." (Closed)

Created:
7 years, 7 months ago by not at google - send to devlin

Modified:
7 years, 7 months ago

Reviewers:
samusaaron3

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

Merge 199135 "Fix mismatched parameter expectations between chro..." > Fix mismatched parameter expectations between chrome.omnibox setDefaultSuggestion and SuggestResult > Adds new DefaultSuggestResult type to the omnibox json schema > > BUG=237817 > > Review URL: https://chromiumcodereview.appspot.com/14960004 TBR=Samusaaron3@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199614

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -13 lines)			Patch
M	chrome/browser/extensions/api/omnibox/omnibox_api.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/api/omnibox/omnibox_unittest.cc	View	2 chunks	+40 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/omnibox.json	View	5 chunks	+51 lines, -7 lines	0 comments	Download
M	chrome/renderer/resources/extensions/omnibox_custom_bindings.js	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

not at google - send to devlin

7 years, 7 months ago (2013-05-11 18:41:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r199614.