Chromium Code Reviews

Issue 1459183002: [crankshaft] Pass new.target to direct function calls. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Pass new.target to direct function calls. This changes all direct function calls in Crankshaft to pass undefined via the register expected to hold the new.target value. Note that the register is still ignored by all callees for now. This is a preparatory CL to allows us passing new.target in a register instead of via a side-channel through the construct stub frame. R=bmeurer@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/e2bce9d392244b9f37929b68e9df641831c5075e Cr-Commit-Position: refs/heads/master@{#32125}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+48 lines, -24 lines)
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +6 lines, -3 lines 0 comments
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +6 lines, -3 lines 0 comments
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +6 lines, -3 lines 0 comments
M src/crankshaft/mips/lithium-codegen-mips.cc View 2 chunks +6 lines, -3 lines 0 comments
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +6 lines, -3 lines 0 comments
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +6 lines, -3 lines 0 comments
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +6 lines, -3 lines 0 comments
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +6 lines, -3 lines 0 comments

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-19 14:48:49 UTC) #1
Benedikt Meurer
LGTM.
5 years, 1 month ago (2015-11-19 14:49:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459183002/1
5 years, 1 month ago (2015-11-19 14:54:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11922)
5 years, 1 month ago (2015-11-19 14:56:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459183002/1
5 years, 1 month ago (2015-11-19 19:02:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 19:33:49 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 19:34:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2bce9d392244b9f37929b68e9df641831c5075e
Cr-Commit-Position: refs/heads/master@{#32125}

Powered by Google App Engine