Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1191)

Unified Diff: runtime/vm/isolate.cc

Issue 1459173004: Remove support for object grouping during Garbage Collection (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code-review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index bdacc45b0deb5f7724a6a3d2e5321943b6dcdc9f..97c3d10d3006807a9901499322a8a4481fd47b60 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1646,7 +1646,6 @@ void Isolate::LowLevelShutdown() {
// Finalize any weak persistent handles with a non-null referent.
FinalizeWeakPersistentHandlesVisitor visitor;
api_state()->weak_persistent_handles().VisitHandles(&visitor);
- api_state()->prologue_weak_persistent_handles().VisitHandles(&visitor);
if (FLAG_trace_isolates) {
heap()->PrintSizes();
@@ -1755,15 +1754,13 @@ Isolate* Isolate::isolates_list_head_ = NULL;
bool Isolate::creation_enabled_ = false;
void Isolate::IterateObjectPointers(ObjectPointerVisitor* visitor,
- bool visit_prologue_weak_handles,
bool validate_frames) {
HeapIterationScope heap_iteration_scope;
- VisitObjectPointers(visitor, visit_prologue_weak_handles, validate_frames);
+ VisitObjectPointers(visitor, validate_frames);
}
void Isolate::VisitObjectPointers(ObjectPointerVisitor* visitor,
- bool visit_prologue_weak_handles,
bool validate_frames) {
ASSERT(visitor != NULL);
@@ -1778,7 +1775,7 @@ void Isolate::VisitObjectPointers(ObjectPointerVisitor* visitor,
// Visit the dart api state for all local and persistent handles.
if (api_state() != NULL) {
- api_state()->VisitObjectPointers(visitor, visit_prologue_weak_handles);
+ api_state()->VisitObjectPointers(visitor);
}
// Visit the current tag which is stored in the isolate.
@@ -1819,17 +1816,9 @@ void Isolate::VisitObjectPointers(ObjectPointerVisitor* visitor,
}
-void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor,
- bool visit_prologue_weak_handles) {
+void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor) {
if (api_state() != NULL) {
- api_state()->VisitWeakHandles(visitor, visit_prologue_weak_handles);
- }
-}
-
-
-void Isolate::VisitPrologueWeakPersistentHandles(HandleVisitor* visitor) {
- if (api_state() != NULL) {
- api_state()->VisitPrologueWeakHandles(visitor);
+ api_state()->VisitWeakHandles(visitor);
}
}
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698