Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1459173004: Remove support for object grouping during Garbage Collection (Closed)

Created:
5 years, 1 month ago by siva
Modified:
5 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove support for object grouping during Garbage Collection - remove support for prolog weak persistent handles - remove support for construction of weak reference sets R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/4992bc72a0565cff507fb8aa94ce3fd330467cf9

Patch Set 1 #

Total comments: 2

Patch Set 2 : code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1188 lines) Patch
M runtime/include/dart_api.h View 1 chunk +0 lines, -134 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 9 chunks +4 lines, -163 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 5 chunks +0 lines, -506 lines 0 comments Download
M runtime/vm/dart_api_state.h View 1 10 chunks +5 lines, -165 lines 0 comments Download
M runtime/vm/gc_marker.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/gc_marker.cc View 10 chunks +6 lines, -84 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/isolate.cc View 4 chunks +4 lines, -15 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object_graph.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/scavenger.h View 1 chunk +2 lines, -6 lines 0 comments Download
M runtime/vm/scavenger.cc View 6 chunks +8 lines, -94 lines 0 comments Download
M runtime/vm/thread_test.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M runtime/vm/verifier.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 1 month ago (2015-11-20 01:35:35 UTC) #2
Ivan Posva
Pure deletion of code: This is the best kind of optimization! LGTM -Ivan https://codereview.chromium.org/1459173004/diff/1/runtime/vm/dart_api_state.h File ...
5 years, 1 month ago (2015-11-20 04:52:05 UTC) #3
siva
https://codereview.chromium.org/1459173004/diff/1/runtime/vm/dart_api_state.h File runtime/vm/dart_api_state.h (right): https://codereview.chromium.org/1459173004/diff/1/runtime/vm/dart_api_state.h#newcode259 runtime/vm/dart_api_state.h:259: kExternalSizeBitsSize = (kBitsPerWord - 2), On 2015/11/20 04:52:05, Ivan ...
5 years, 1 month ago (2015-11-20 17:11:42 UTC) #4
siva
5 years, 1 month ago (2015-11-20 20:36:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4992bc72a0565cff507fb8aa94ce3fd330467cf9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698