Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1459163003: Revert of media::FFmpegVideoDecoder: remove ctor param |task_runner| and use a ThreadChecker instead. (Closed)

Created:
5 years, 1 month ago by mcasas
Modified:
5 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media::FFmpegVideoDecoder: remove ctor param |task_runner| and use a ThreadChecker instead. (patchset #1 id:20001 of https://codereview.chromium.org/1456993004/ ) Reason for revert: Broke compilation in a Mac bot (https://chromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/20908) (I wonder why the CQ passed) http://crbug.com/558587 Original issue's description: > media::FFmpegVideoDecoder: remove ctor param |task_runner| and use a ThreadChecker instead. > > This CL removed the |task_runner| passed on construction to > FFmpegVideoDecoder since: "... is used in just one location > for PostTask()ing. The class itself is otherwise mostly single > threaded (except perhaps construction), and passing a > |task_runner| as ctor argument is confusingly indicating the > opposite. A |thread_checker_| basically tells that a(ll) methods > are run in a given thread, whichever this is." > (from discussion in http://crrev.com/1438233003, which has > sadly been reverted for unrelated issues, and is going to be > relanded as http://crrev.com/1447343004). > > Removal of this |task_runner| is also necessary for using these > two classes from WebRtc, see the linekd bug. > > BUG=554737 > > TEST=This is a tiny change, all unittest and content_browsertests should cover it. > > Committed: https://crrev.com/97e43b3e9b64da825f925a047b8d91e75260fd82 > Cr-Commit-Position: refs/heads/master@{#360628} TBR=dalecurtis@chromium.org,chcunningham@chromium.org,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554737 Committed: https://crrev.com/506a31cfd353a555fbc92b8c642a01cc7675088d Cr-Commit-Position: refs/heads/master@{#360649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M content/common/gpu/media/video_encode_accelerator_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/video_decoder_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
mcasas
5 years, 1 month ago (2015-11-19 20:09:48 UTC) #1
Created Revert of media::FFmpegVideoDecoder: remove ctor param |task_runner| and
use a ThreadChecker instead.

Powered by Google App Engine
This is Rietveld 408576698