Remove ScopedVector from trace_buffer

Remove ScopedVector from trace_buffer

BUG=554289
Committed: https://crrev.com/f84df22e5684239371c53d4a9f0bab6229711a64
Cr-Commit-Position: refs/heads/master@{#361965}

[Olli Raula, 2015-11-19 16:11:17]

Description was changed from

==========
Remove ScopedVector from trace_buffer

BUG=554289
==========

to

==========
Remove ScopedVector from trace_buffer

BUG=554289
==========

[Olli Raula, 2015-11-19 16:11:17]

olli.raula@intel.com changed reviewers:
+ nduca@chromium.org

[Olli Raula, 2015-11-19 16:11:42]

Could you review?

[Primiano Tucci (use gerrit), 2015-11-24 10:38:03]

primiano@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2015-11-24 10:38:03]

I can take these reviews, just back from vacation.
I'm asking for clarifications on cxx@chromium.org, still not clear whether we
can use c++11 lib features in base/

See discussion in
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/gKRtFBugpeA

[Olli Raula, 2015-11-26 12:00:18]

On 2015/11/24 10:38:03, Primiano Tucci wrote:
> I can take these reviews, just back from vacation.
> I'm asking for clarifications on mailto:cxx@chromium.org, still not clear
whether we
> can use c++11 lib features in base/
> 
> See discussion in
> https://groups.google.com/a/chromium.org/forum/#!topic/cxx/gKRtFBugpeA

This is also fine?

[Primiano Tucci (use gerrit), 2015-11-26 15:47:15]

LGTM but fix the headers please

https://codereview.chromium.org/1459143002/diff/1/base/trace_event/trace_buff...
File base/trace_event/trace_buffer.cc (right):

https://codereview.chromium.org/1459143002/diff/1/base/trace_event/trace_buff...
base/trace_event/trace_buffer.cc:7: #include "base/memory/scoped_vector.h"
remove this and add <vector> and scoped_ptr plz :)

https://codereview.chromium.org/1459143002/diff/1/base/trace_event/trace_buff...
base/trace_event/trace_buffer.cc:106: cloned_buffer->chunks_.push_back(chunk ?
chunk->Clone()
doesn't this fit on one line?

[Olli Raula, 2015-11-27 07:57:54]

The CQ bit was checked by olli.raula@intel.com

[Olli Raula, 2015-11-27 07:57:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1459143002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2015-11-27 07:58:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1459143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1459143002/40001

[commit-bot: I haz the power, 2015-11-27 09:26:30]

Description was changed from

==========
Remove ScopedVector from trace_buffer

BUG=554289
==========

to

==========
Remove ScopedVector from trace_buffer

BUG=554289
==========

[commit-bot: I haz the power, 2015-11-27 09:26:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-27 09:27:23]

Description was changed from

==========
Remove ScopedVector from trace_buffer

BUG=554289
==========

to

==========
Remove ScopedVector from trace_buffer

BUG=554289

Committed: https://crrev.com/f84df22e5684239371c53d4a9f0bab6229711a64
Cr-Commit-Position: refs/heads/master@{#361965}
==========

[commit-bot: I haz the power, 2015-11-27 09:27:24]

Patchset 3 (id:??) landed as
https://crrev.com/f84df22e5684239371c53d4a9f0bab6229711a64
Cr-Commit-Position: refs/heads/master@{#361965}