chrome/test/chromedriver/chrome/console_logger_unittest.cc - Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/console_logger_unittest.cc

Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Update to head. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/console_logger.cc ('K') | « chrome/test/chromedriver/chrome/console_logger.cc ('k') | chrome/test/chromedriver/chrome/log.h » ('j') | chrome/test/chromedriver/chrome/log.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/console_logger_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/console_logger_unittest.cc b/chrome/test/chromedriver/chrome/console_logger_unittest.cc

index deae61b0538db0e9cb486668d15183f4958e25b8..45bce56b944d2c2769fd5f23dacd2b694c1f14bb 100644

--- a/chrome/test/chromedriver/chrome/console_logger_unittest.cc

+++ b/chrome/test/chromedriver/chrome/console_logger_unittest.cc

@@ -182,3 +182,4 @@ TEST(ConsoleLogger, ConsoleMessages) {

"\"source\":\"source7\",\"url\":\"url7\"}}");

ValidateLogEntry(log.entries[7], Log::kWarning, "{\"gaga\":8}");

}