chrome/test/chromedriver/chrome/performance_logger.cc - Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/performance_logger.cc

Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Fix types in CHECK comparisons. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/performance_logger.h ('k') | chrome/test/chromedriver/chrome/performance_logger_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/performance_logger.cc

diff --git a/chrome/test/chromedriver/chrome/performance_logger.cc b/chrome/test/chromedriver/chrome/performance_logger.cc

index d2d5d12e100f2ea78cf67db809cb5f84b7f2569f..77ab25c290fffb7ed20bc1116638f38416fec67d 100644

--- a/chrome/test/chromedriver/chrome/performance_logger.cc

+++ b/chrome/test/chromedriver/chrome/performance_logger.cc

@@ -14,16 +14,16 @@

namespace {

// DevTools event domain prefixes to intercept.

-const char* kDomains[] = {"Network.", "Page.", "Timeline."};

+const char* const kDomains[] = {"Network.", "Page.", "Timeline."};

-const char* kDomainEnableCommands[] = {

+const char* const kDomainEnableCommands[] = {

"Network.enable", "Page.enable", "Timeline.start"

};

// Returns whether the event belongs to one of kDomains.

bool ShouldLogEvent(const std::string& method) {

for (size_t i_domain = 0; i_domain < arraysize(kDomains); ++i_domain) {

- if (StartsWithASCII(method, kDomains[i_domain], true))

+ if (StartsWithASCII(method, kDomains[i_domain], true /* case_sensitive */))

return true;

}

return false;