Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: chrome/test/chromedriver/chrome/console_logger.h

Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Rewrite ConsoleLogger::OnEvent from stringstream to printf. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/console_logger.h
diff --git a/chrome/test/chromedriver/chrome/console_logger.h b/chrome/test/chromedriver/chrome/console_logger.h
index de092681d8a33c71d49a96e567aa23044042235c..058c321bfe87cfec74b94ccbe756a6ad45c7dedc 100644
--- a/chrome/test/chromedriver/chrome/console_logger.h
+++ b/chrome/test/chromedriver/chrome/console_logger.h
@@ -19,15 +19,19 @@ class Log;
// Translates the level into Log::Level, drops all other fields.
class ConsoleLogger : public DevToolsEventListener {
public:
+ // Creates a ConsoleLogger that creates entries in the given Log object.
+ // The log is owned elsewhere and must not be NULL.
jdennett 2013/05/23 03:44:24 Optional: I try to reserve all-caps NULL for the n
klm 2013/05/23 15:21:39 Done.
explicit ConsoleLogger(Log* log);
+ // Enables Console events for the client, which must not be NULL.
virtual Status OnConnected(DevToolsClient* client) OVERRIDE;
+ // Translates an event into a log entry.
virtual void OnEvent(DevToolsClient* client,
const std::string& method,
const base::DictionaryValue& params) OVERRIDE;
private:
- Log* log_;
+ Log* log_; // The log where to create entries.
DISALLOW_COPY_AND_ASSIGN(ConsoleLogger);
};
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/console_logger.cc » ('j') | chrome/test/chromedriver/chrome/console_logger.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698