chrome/test/chromedriver/logging_unittest.cc - Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Update to head. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/chromedriver/logging.cc ('K') | « chrome/test/chromedriver/logging.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/test/chromedriver/logging.h"	5 #include "chrome/test/chromedriver/logging.h"

6	6

7 #include "base/values.h"	7 #include "base/values.h"

8 #include "chrome/test/chromedriver/capabilities.h"	8 #include "chrome/test/chromedriver/capabilities.h"

9 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h"	9 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h"

10 #include "chrome/test/chromedriver/chrome/status.h"	10 #include "chrome/test/chromedriver/chrome/status.h"

(...skipping 146 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
157 ASSERT_EQ(1u, listeners.size());	157 ASSERT_EQ(1u, listeners.size());

158 ASSERT_STREQ("browser", logs[0]->GetType().c_str());	158 ASSERT_STREQ("browser", logs[0]->GetType().c_str());

159	159

160 // Verify the created "browser" log is "INFO" level.	160 // Verify the created "browser" log is "INFO" level.

161 logs[0]->AddEntry(Log::kLog, "info message");	161 logs[0]->AddEntry(Log::kLog, "info message");

162 logs[0]->AddEntry(Log::kDebug, "drop debug message");	162 logs[0]->AddEntry(Log::kDebug, "drop debug message");

163 scoped_ptr<base::ListValue> entries(logs[0]->GetAndClearEntries());	163 scoped_ptr<base::ListValue> entries(logs[0]->GetAndClearEntries());

164 ASSERT_EQ(1u, entries->GetSize());	164 ASSERT_EQ(1u, entries->GetSize());

165 ValidateLogEntry(entries.get(), 0, "INFO", "info message");	165 ValidateLogEntry(entries.get(), 0, "INFO", "info message");

166 }	166 }

	167

OLD	NEW