chrome/test/chromedriver/logging.h - Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/logging.h

Issue 14591005: C++ readability review from original change https://chromiumcodereview.appspot.com/14263024/ (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/

Patch Set: Update to head. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/chromedriver/chrome/performance_logger_unittest.cc ('K') | « chrome/test/chromedriver/chrome/performance_logger_unittest.cc ('k') | chrome/test/chromedriver/logging.cc » ('j') | chrome/test/chromedriver/logging.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_TEST_CHROMEDRIVER_LOGGING_H_	5 #ifndef CHROME_TEST_CHROMEDRIVER_LOGGING_H_

6 #define CHROME_TEST_CHROMEDRIVER_LOGGING_H_	6 #define CHROME_TEST_CHROMEDRIVER_LOGGING_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53	53

54 DISALLOW_COPY_AND_ASSIGN(WebDriverLog);	54 DISALLOW_COPY_AND_ASSIGN(WebDriverLog);

55 };	55 };

56	56

57 // Creates Log's and DevToolsEventListener's for ones that are DevTools-based.	57 // Creates Log's and DevToolsEventListener's for ones that are DevTools-based.

58 Status CreateLogs(const Capabilities& capabilities,	58 Status CreateLogs(const Capabilities& capabilities,

59 ScopedVector<WebDriverLog>* out_devtools_logs,	59 ScopedVector<WebDriverLog>* out_devtools_logs,

60 ScopedVector<DevToolsEventListener>* out_listeners);	60 ScopedVector<DevToolsEventListener>* out_listeners);

61	61

62 #endif // CHROME_TEST_CHROMEDRIVER_LOGGING_H_	62 #endif // CHROME_TEST_CHROMEDRIVER_LOGGING_H_

	63

OLD	NEW