Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1459063004: Use invalidation sets for visited link updates. (Closed)

Created:
5 years, 1 month ago by rune
Modified:
5 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use invalidation sets for visited link updates. We did use invalidation sets when adding/removing href from an anchor tag, while the code that notifies that the visited state of a given url has changed, use SubtreeStyleChange. This change gets rid of SubtreeStyleChange which relies on sibling tree recalcs. R=tkent@chromium.org BUG=557440 Committed: https://crrev.com/038590ac56052630a62d61c43a54e9dcf1748da8 Cr-Commit-Position: refs/heads/master@{#361121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/VisitedLinkState.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459063004/1
5 years, 1 month ago (2015-11-20 10:19:46 UTC) #2
rune
I wrote a webkit_unit_test, but it didn't work because the Platform object always return 0 ...
5 years, 1 month ago (2015-11-20 10:27:46 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-20 11:41:25 UTC) #5
tkent
lgtm
5 years ago (2015-11-23 14:41:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459063004/1
5 years ago (2015-11-23 14:49:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 16:26:56 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-23 16:27:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/038590ac56052630a62d61c43a54e9dcf1748da8
Cr-Commit-Position: refs/heads/master@{#361121}

Powered by Google App Engine
This is Rietveld 408576698