Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1459033003: avoid 'may be used uninitialized' warnings in stack_sampling_profiler_unittest.cc (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
Reviewers:
Mike Wittman
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

avoid 'may be used uninitialized' warnings in stack_sampling_profiler_unittest.cc Without this patch, some toolchains may trigger this warning: ../../base/profiler/stack_sampling_profiler_unittest.cc:275:17: error: 'library' may be used uninitialized in this function [-Werror=maybe-uninitialized] BUG=545051 Committed: https://crrev.com/ad716fc243dac9ea3e950d1cc1adc1abbd71a90d Cr-Commit-Position: refs/heads/master@{#360647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/profiler/stack_sampling_profiler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459033003/1
5 years, 1 month ago (2015-11-19 09:05:16 UTC) #2
Mostyn Bramley-Moore
@Mike: please take a look at this small followup to https://codereview.chromium.org/1423583002
5 years, 1 month ago (2015-11-19 09:05:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 10:35:03 UTC) #6
Mike Wittman
lgtm
5 years, 1 month ago (2015-11-19 16:14:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459033003/1
5 years, 1 month ago (2015-11-19 19:45:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 20:06:50 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 20:08:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad716fc243dac9ea3e950d1cc1adc1abbd71a90d
Cr-Commit-Position: refs/heads/master@{#360647}

Powered by Google App Engine
This is Rietveld 408576698