Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1459033002: Replace (most) occurrences of mojo::Array<T>() with nullptr. (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Replace (most) occurrences of mojo::Array<T>() with nullptr. I added the (implicit) Array<T>(nullptr_t) ctor in f2b68aa98482b4668b0afcb66c45ab853a2a4a08. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/06341ac4bc0cbf1efc660b414a5a42ef87aa01f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M apps/moterm/moterm_driver.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/files/cpp/lib/input_stream_file.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M mojo/services/files/cpp/lib/output_stream_file.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M services/files/directory_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/files/file_impl.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M services/files/file_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 1 month ago (2015-11-19 01:33:41 UTC) #1
viettrungluu
ping
5 years, 1 month ago (2015-11-19 20:24:29 UTC) #2
vardhan
lgtm
5 years, 1 month ago (2015-11-19 20:31:47 UTC) #3
viettrungluu
5 years, 1 month ago (2015-11-19 21:02:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06341ac4bc0cbf1efc660b414a5a42ef87aa01f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698