Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1458983002: Don't use global variables for capturing stdio. (Closed)

Created:
5 years, 1 month ago by turnidge
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M runtime/bin/builtin_natives.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/file.h View 2 chunks +16 lines, -0 lines 0 comments Download
M runtime/bin/file.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/bin/main.cc View 2 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 1 month ago (2015-11-18 20:42:13 UTC) #2
Cutch
lgtm
5 years, 1 month ago (2015-11-18 20:43:15 UTC) #3
turnidge
5 years, 1 month ago (2015-11-18 20:47:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1d2d1ce0fcd83d65c68045222157a0fd5b187781 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698