Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1458973002: Deal with missing deopt_table under precompilation. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Cutch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deal with missing deopt_table under precompilation. E.g., the InlinedFunctionsIterator used to build stacktraces. Broken by 73b6080a6b26ad24380477c4a584edd6cb2e2ab5. R=johnmccutchan@google.com, srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/a6e8abfeb6a6789f1fd8d7ff75679ffbd3937b53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-18 20:44:35 UTC) #2
Cutch
lgtm
5 years, 1 month ago (2015-11-18 20:47:11 UTC) #3
srdjan
lgtm
5 years, 1 month ago (2015-11-18 20:52:07 UTC) #4
rmacnak
5 years, 1 month ago (2015-11-18 21:02:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6e8abfeb6a6789f1fd8d7ff75679ffbd3937b53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698