Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1458943002: restore dump_record (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

restore dump_record And, - 4 space indents - print out time units (microseconds) BUG=skia: Committed: https://skia.googlesource.com/skia/+/2f2903d7a0bad75014880753f4809c3b12788a82

Patch Set 1 #

Patch Set 2 : tidy #

Patch Set 3 : return #

Patch Set 4 : toint #

Patch Set 5 : (int) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -19 lines) Patch
M gyp/tools.gyp View 2 chunks +18 lines, -0 lines 0 comments Download
M tools/DumpRecord.cpp View 1 2 3 4 3 chunks +17 lines, -19 lines 0 comments Download
A tools/dump_record.cpp View 1 2 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
mtklein_C
5 years, 1 month ago (2015-11-18 18:19:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458943002/20001
5 years, 1 month ago (2015-11-18 18:19:16 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/4298)
5 years, 1 month ago (2015-11-18 18:20:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458943002/40001
5 years, 1 month ago (2015-11-18 18:25:15 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4297) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 1 month ago (2015-11-18 18:27:36 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458943002/60001
5 years, 1 month ago (2015-11-18 18:35:24 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4299) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 1 month ago (2015-11-18 18:37:26 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458943002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458943002/80001
5 years, 1 month ago (2015-11-18 18:45:31 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 18:57:44 UTC) #18
mtklein
lgtm
5 years, 1 month ago (2015-11-18 19:05:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458943002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458943002/80001
5 years, 1 month ago (2015-11-18 19:06:00 UTC) #21
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 19:06:40 UTC) #22
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/2f2903d7a0bad75014880753f4809c3b12788a82

Powered by Google App Engine
This is Rietveld 408576698