A64: Fix handling of Smis in lithium Load/Store.

A64: Fix handling of Smis in lithium Load/Store.

BUG=
R=jochen@chromium.org, m.m.capewell@googlemail.com

Committed: https://code.google.com/p/v8/source/detail?r=19205

[ulan, 2014-02-07 15:43:05]

This ports Smi optimizations for x64 in r18283, r18359, r18360, r18362 and fixes
many test failures.

[jochen (gone - plz use gerrit), 2014-02-07 15:53:09]

lgtm

[m.m.capewell, 2014-02-07 15:56:50]

https://codereview.chromium.org/145893004/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/145893004/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3478: instr->hydrogen()->elements_kind() ==
FAST_SMI_ELEMENTS) {
Perhaps assert the format of a smi here and in store below.
STATIC_ASSERT((kSmiValueSize == 32) && (kSmiShift == 32) && (kSmiTag == 0));

[ulan, 2014-02-07 16:08:09]

PTAL

https://codereview.chromium.org/145893004/diff/1/src/a64/lithium-codegen-a64.cc
File src/a64/lithium-codegen-a64.cc (right):

https://codereview.chromium.org/145893004/diff/1/src/a64/lithium-codegen-a64....
src/a64/lithium-codegen-a64.cc:3478: instr->hydrogen()->elements_kind() ==
FAST_SMI_ELEMENTS) {
On 2014/02/07 15:56:50, m.m.capewell wrote:
> Perhaps assert the format of a smi here and in store below.
> STATIC_ASSERT((kSmiValueSize == 32) && (kSmiShift == 32) && (kSmiTag == 0));

Done.

[ulan, 2014-02-07 16:09:43]

The last patch set is broken. I will re-upload shortly.

[ulan, 2014-02-07 16:12:59]

I uploaded new patch set with static asserts, PTAL.

[m.m.capewell, 2014-02-07 16:16:41]

lgtm

[ulan, 2014-02-07 16:25:50]

Committed patchset #3 manually as r19205 (presubmit successful).