Issue 145893002: mac: Fix build with 10.7+ sdk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 145893002: mac: Fix build with 10.7+ sdk. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
Robert Sesek

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

mac: Fix build with 10.7+ sdk. BUG=306348 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165650

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	Source/web/mac/WebScrollbarTheme.cpp	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

6 years, 11 months ago (2014-01-23 18:07:22 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/145893002/diff/1/Source/web/mac/WebScrollbarT...
File Source/web/mac/WebScrollbarTheme.cpp (right):

https://codereview.chromium.org/145893002/diff/1/Source/web/mac/WebScrollbarT...
Source/web/mac/WebScrollbarTheme.cpp:43: C//OMPILE_ASSERT(ScrollerStyleOverlay
== NSScrollerStyleOverlay, ScrollerStyle_Overlay_must_be_equal);
Off by one char

Expand Messages | Collapse Messages