components/autofill/core/browser/autofill_external_delegate.h - Issue 1458903003: [Autofill] Deduplicate Autocomplete and Datalist suggestions, keeping the latter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 1458903003: [Autofill] Deduplicate Autocomplete and Datalist suggestions, keeping the latter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/autofill_external_delegate.h

diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h

index 45ab4c288a57c1d5499444f95ad37c326bab78f1..24bc816fba8ca82c485e486edea52625f3323871 100644

--- a/components/autofill/core/browser/autofill_external_delegate.h

+++ b/components/autofill/core/browser/autofill_external_delegate.h

@@ -109,7 +109,9 @@ class AutofillExternalDelegate : public AutofillPopupDelegate {

void ApplyAutofillOptions(std::vector<Suggestion>* suggestions);

// Insert the data list values at the start of the given list, including

- // any required separators.

+ // any required separators. Will also go through |suggestions| and remove

+ // duplicate autocomplete (not Autofill) suggestions, keeping their datalist

+ // version.

void InsertDataListValues(std::vector<Suggestion>* suggestions);

AutofillManager* manager_; // weak.

« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | no next file with comments »