Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 1458903003: [Autofill] Deduplicate Autocomplete and Datalist suggestions, keeping the latter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lambda function Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate.h
diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h
index 45ab4c288a57c1d5499444f95ad37c326bab78f1..689b177f5e40028512f92331483b9dbe0b6a2188 100644
--- a/components/autofill/core/browser/autofill_external_delegate.h
+++ b/components/autofill/core/browser/autofill_external_delegate.h
@@ -109,7 +109,9 @@ class AutofillExternalDelegate : public AutofillPopupDelegate {
void ApplyAutofillOptions(std::vector<Suggestion>* suggestions);
// Insert the data list values at the start of the given list, including
- // any required separators.
+ // any required separators. Will also go through |suggestions| and remove
+ // duplicate autocomplete (not autofill) suggestions, keeping their datalist
Evan Stade 2015/11/19 16:40:10 nit: Autofill is capitalized
Mathieu 2015/11/19 17:06:21 Done.
+ // version.
void InsertDataListValues(std::vector<Suggestion>* suggestions);
AutofillManager* manager_; // weak.

Powered by Google App Engine
This is Rietveld 408576698