Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2374)

Unified Diff: chrome/browser/extensions/api/system_private/system_private_apitest.cc

Issue 14589017: Use MockDBusThreadManagerWithoutGMock for GetUpdateStatusApiTest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename to default_status_ Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_private/system_private_apitest.cc
diff --git a/chrome/browser/extensions/api/system_private/system_private_apitest.cc b/chrome/browser/extensions/api/system_private/system_private_apitest.cc
index 725b0504f01e47d9f713a0fc270ca26429865089..6e3d3419bcc2a2d3875589b4111e1cfb3eafdae7 100644
--- a/chrome/browser/extensions/api/system_private/system_private_apitest.cc
+++ b/chrome/browser/extensions/api/system_private/system_private_apitest.cc
@@ -9,11 +9,10 @@
#include "chrome/common/pref_names.h"
#if defined(OS_CHROMEOS)
-#include "chromeos/dbus/mock_dbus_thread_manager.h"
-#include "chromeos/dbus/mock_update_engine_client.h"
+#include "chromeos/dbus/fake_update_engine_client.h"
+#include "chromeos/dbus/mock_dbus_thread_manager_without_gmock.h"
using chromeos::UpdateEngineClient;
-using ::testing::Return;
#endif
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, GetIncognitoModeAvailability) {
@@ -28,18 +27,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, GetIncognitoModeAvailability) {
class GetUpdateStatusApiTest : public ExtensionApiTest {
public:
- GetUpdateStatusApiTest() : mock_update_engine_client_(NULL) {}
+ GetUpdateStatusApiTest() : fake_update_engine_client_(NULL) {}
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
ExtensionApiTest::SetUpInProcessBrowserTestFixture();
- chromeos::MockDBusThreadManager* mock_dbus_thread_manager =
- new chromeos::MockDBusThreadManager;
+ chromeos::MockDBusThreadManagerWithoutGMock* mock_dbus_thread_manager =
+ new chromeos::MockDBusThreadManagerWithoutGMock;
chromeos::DBusThreadManager::InitializeForTesting(mock_dbus_thread_manager);
- mock_update_engine_client_ =
- mock_dbus_thread_manager->mock_update_engine_client();
- EXPECT_CALL(*mock_update_engine_client_, GetLastStatus())
- .Times(1)
- .WillOnce(Return(chromeos::MockUpdateEngineClient::Status()));
+ fake_update_engine_client_ =
+ mock_dbus_thread_manager->fake_update_engine_client();
}
virtual void TearDownInProcessBrowserTestFixture() OVERRIDE {
@@ -48,7 +44,7 @@ class GetUpdateStatusApiTest : public ExtensionApiTest {
}
protected:
- chromeos::MockUpdateEngineClient* mock_update_engine_client_;
+ chromeos::FakeUpdateEngineClient* fake_update_engine_client_;
private:
DISALLOW_COPY_AND_ASSIGN(GetUpdateStatusApiTest);
@@ -64,10 +60,11 @@ IN_PROC_BROWSER_TEST_F(GetUpdateStatusApiTest, Progress) {
status_boot_needed.status =
UpdateEngineClient::UPDATE_STATUS_UPDATED_NEED_REBOOT;
- EXPECT_CALL(*mock_update_engine_client_, GetLastStatus())
- .WillOnce(Return(status_not_available))
- .WillOnce(Return(status_updating))
- .WillOnce(Return(status_boot_needed));
+ // The fake client returns the last status in this order.
+ fake_update_engine_client_->PushLastStatus(status_not_available);
+ fake_update_engine_client_->PushLastStatus(status_updating);
+ fake_update_engine_client_->PushLastStatus(status_boot_needed);
+
ASSERT_TRUE(RunComponentExtensionTest(
"system/get_update_status")) << message_;
}

Powered by Google App Engine
This is Rietveld 408576698