Unit test for BrowserViewLayout that does not depend on BrowserView

chrome/browser/ui/views/frame/browser_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 24 matching lines @@
 #include "chrome/browser/hang_monitor/hung_plugin_action.h"
 #include "chrome/browser/hang_monitor/hung_window_detector.h"
 #endif
 
 // NOTE: For more information about the objects and files in this directory,
 // view: http://dev.chromium.org/developers/design-documents/browser-window
 
 class BookmarkBarView;
 class Browser;
 class BrowserViewLayout;
+class BrowserViewLayoutDelegate;
 class ContentsContainer;
 class DownloadShelfView;
 class FullscreenExitBubbleViews;
 class ImmersiveModeController;
 class InfoBarContainerView;
 class InstantOverlayControllerViews;
 class LocationBarView;
 class OverlayContainer;
 class StatusBubbleViews;
 class SearchViewController;
@@ skipping 398 matching lines @@
   views::SingleSplitView* GetContentsSplitForTest() { return contents_split_; }
   ContentsContainer* GetContentsContainerForTest() {
     return contents_container_;
   }
   OverlayContainer* GetOverlayContainerForTest() {
     return overlay_container_;
   }
   views::WebView* GetContentsWebViewForTest() { return contents_web_view_; }
 
  private:
-  friend class BrowserViewLayout;
+  // Do not friend BrowserViewLayout. Use the BrowserViewLayoutDelegate
+  // interface to keep these two classes decoupled and testable.
+  friend class BrowserViewLayoutDelegateImpl;
   FRIEND_TEST_ALL_PREFIXES(BrowserViewTest, BrowserView);
   FRIEND_TEST_ALL_PREFIXES(BrowserViewsAccessibilityTest,
                            TestAboutChromeViewAccObj);
 
   enum FullscreenType {
     FOR_DESKTOP,
     FOR_METRO
   };
 
   // We store this on linux because we must call ProcessFullscreen()
@@ skipping 132 matching lines @@
 
   // Last focused view that issued a tab traversal.
   int last_focused_view_storage_id_;
 
   // The BrowserFrame that hosts this view.
   BrowserFrame* frame_;
 
   // The Browser object we are associated with.
   scoped_ptr<Browser> browser_;
 
+  // Delegate implementation for BrowserViewLayout. Exists as a member because
+  // some methods have the same names as BrowserWindow overrides.
+  scoped_ptr<BrowserViewLayoutDelegate> layout_delegate_;
+
   // BrowserView layout (LTR one is pictured here).
   //
   // --------------------------------------------------------------------
   // | TopContainerView (top_container_)                                |
   // |  --------------------------------------------------------------  |
   // |  | Tabs (tabstrip_)                                           |  |
   // |  |------------------------------------------------------------|  |
   // |  | Navigation buttons, address bar, menu (toolbar_)           |  |
   // |  --------------------------------------------------------------  |
   // |------------------------------------------------------------------|
@@ skipping 149 matching lines @@
   gfx::ScopedSysColorChangeListener color_change_listener_;
 
   scoped_ptr<InstantOverlayControllerViews> overlay_controller_;
 
   mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_