Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1458883007: QUIC - minor cleanup of duplicated code in ProofVerifierChromiumTest. (Closed)

Created:
5 years, 1 month ago by ramant (doing other things)
Modified:
5 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ssl_reorg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - minor cleanup of duplicated code in ProofVerifierChromiumTest. R=rch@chromium.org Committed: https://crrev.com/2ee275263407858e74f7dd108c156fc44ab8c53f Cr-Commit-Position: refs/heads/master@{#360655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -121 lines) Patch
M net/quic/crypto/proof_verifier_chromium_test.cc View 6 chunks +90 lines, -121 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
ramant (doing other things)
5 years, 1 month ago (2015-11-19 17:39:06 UTC) #1
ramant (doing other things)
Hi Ryan, While implementing tests for CTVerifier, saw some of the duplicated code. Added ProofVerifierChromiumTest ...
5 years, 1 month ago (2015-11-19 17:41:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458883007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458883007/1
5 years, 1 month ago (2015-11-19 17:42:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 18:14:00 UTC) #6
Ryan Hamilton
lgtm
5 years, 1 month ago (2015-11-19 20:03:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458883007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458883007/1
5 years, 1 month ago (2015-11-19 20:11:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 20:31:02 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 20:32:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ee275263407858e74f7dd108c156fc44ab8c53f
Cr-Commit-Position: refs/heads/master@{#360655}

Powered by Google App Engine
This is Rietveld 408576698