Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1458873002: Fix PropertyDescriptor::ToObject (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Michael Hablich, neis
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix PropertyDescriptor::ToObject When adding properties to the result object, that object's prototype chain should be ignored. Committed: https://crrev.com/107699483d0b62b9ccd9e9bab7c997fcf8cae2d8 Cr-Commit-Position: refs/heads/master@{#32085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/property-descriptor.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/property-descriptor-to-object.js View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
This should unblock the roll. Toon: PTAL. Georg, Michael: FYI.
5 years, 1 month ago (2015-11-18 13:36:21 UTC) #2
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-18 13:37:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458873002/1
5 years, 1 month ago (2015-11-18 13:38:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 13:56:23 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 13:57:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/107699483d0b62b9ccd9e9bab7c997fcf8cae2d8
Cr-Commit-Position: refs/heads/master@{#32085}

Powered by Google App Engine
This is Rietveld 408576698