PPAPI/NaCl: Move event dispatching from the plugin

PPAPI/NaCl: Move event dispatching from the plugin

Added chrome/renderer/nacl and OWNERS

Requires the following blink change: https://codereview.chromium.org/14773025/

BUG=239656
R=jam@chromium.org, marja@chromium.org, teravest@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233356

[adamk, 2013-10-23 20:21:56]

Hi there, I happened to be looking at the Blink API this morning and saw some
unused WebDOM*ProgressEvent classes. Are you still planning on landing the
Chromium side?

[dmichael (off chromium), 2013-10-23 20:24:04]

Yes, I'm sorry for this not being landed yet. We've had other priorities trump
this work. The bug should have some information about why we're doing this, and
you can also look at this doc:
https://docs.google.com/a/chromium.org/document/d/1KlseJLJk3A21MZ41r7VW8rVg5q...

Thanks for checking.

[adamk, 2013-10-24 18:25:43]

On 2013/10/23 20:24:04, dmichael wrote:
> Yes, I'm sorry for this not being landed yet. We've had other priorities trump
> this work. The bug should have some information about why we're doing this,
and
> you can also look at this doc:
>
https://docs.google.com/a/chromium.org/document/d/1KlseJLJk3A21MZ41r7VW8rVg5q...
> 
> Thanks for checking.

Thanks for the info. What's the timeline on this? Unused Blink API is likely to
rot, since it's not being exercised by anything; if this isn't going to get
picked up soon I'd recommend we temporarily revert the Blink side of your patch
until the Chromium side is ready to go.

[dmichael (off chromium), 2013-10-24 21:41:38]

On Thu, Oct 24, 2013 at 12:25 PM, <adamk@chromium.org> wrote:

> On 2013/10/23 20:24:04, dmichael wrote:
>
>> Yes, I'm sorry for this not being landed yet. We've had other priorities
>> trump
>> this work. The bug should have some information about why we're doing
>> this,
>>
> and
>
>> you can also look at this doc:
>>
>
> https://docs.google.com/a/**chromium.org/document/d/**
>
1KlseJLJk3A21MZ41r7VW8rVg5qvoE**Ip__uzyAbjL4Lk/edit<https://docs.google.com/a/chromium.org/document/d/1KlseJLJk3A21MZ41r7VW8rVg5qvoEIp__uzyAbjL4Lk/edit>
>
>  Thanks for checking.
>>
>
> Thanks for the info. What's the timeline on this? Unused Blink API is
> likely to
> rot, since it's not being exercised by anything; if this isn't going to get
> picked up soon I'd recommend we temporarily revert the Blink side of your
> patch
> until the Chromium side is ready to go.
>
>
https://codereview.chromium.**org/14588009/<https://codereview.chromium.org/1...
>
I was probably going to leave it for about another month, but if you think
there's risk in doing so, I can revive it now and try to land it within the
next ~week.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmichael (off chromium), 2013-10-25 22:37:12]

teravest: Please review everything.
jam: Please review content/public
marja: Please check my v8 code in ppb_nacl_private_impl.cc. I *think* I've got
the Isolate/Context stuff right, but I want an expert opinion :)

[jam, 2013-10-25 23:12:15]

On 2013/10/25 22:37:12, dmichael wrote:
> jam: Please review content/public

lgtm

[marja, 2013-10-28 07:40:17]

ppb_nacl_private_impl.cc lgtm

Meta: The V8 API is nowadays in a far better shape; if your code compiles, the
chances are it's correct :) Ofc nobody forces you to create a Context or a
HandleScope, so it's still possible to just forget them, but most of the Handle
misuse cases are no longer possible (with the exception of returning a Handle
and destroying the HandleScope which it belongs to).

[teravest, 2013-10-28 14:11:11]

lgtm

[commit-bot: I haz the power, 2013-10-28 14:30:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/14588009/125001

[commit-bot: I haz the power, 2013-10-28 16:29:19]

Retried try job too often on mac_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[teravest1, 2013-10-31 18:39:56]

https://codereview.chromium.org/14588009/diff/125001/chrome/renderer/pepper/p...
File chrome/renderer/pepper/ppb_nacl_private_impl.cc (right):

https://codereview.chromium.org/14588009/diff/125001/chrome/renderer/pepper/p...
chrome/renderer/pepper/ppb_nacl_private_impl.cc:392: WebKit::WebFrame* frame =
container->element().document().frame();
Why do you set frame here and check if it's non-NULL?

[dmichael (off chromium), 2013-10-31 20:08:08]

https://codereview.chromium.org/14588009/diff/125001/chrome/renderer/pepper/p...
File chrome/renderer/pepper/ppb_nacl_private_impl.cc (right):

https://codereview.chromium.org/14588009/diff/125001/chrome/renderer/pepper/p...
chrome/renderer/pepper/ppb_nacl_private_impl.cc:392: WebKit::WebFrame* frame =
container->element().document().frame();
Ah, yes, I don't use it :-). This is probably a bad copy/paste, thanks for
pointing it out; I'll fix it in the next patch set.

[commit-bot: I haz the power, 2013-11-02 14:36:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/14588009/125001

[commit-bot: I haz the power, 2013-11-02 14:56:48]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-04 18:09:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/14588009/605001

[commit-bot: I haz the power, 2013-11-04 21:13:50]

Retried try job too often on mac_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-11-05 23:31:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/14588009/865001

[commit-bot: I haz the power, 2013-11-06 00:07:52]

Failed to trigger a try job on mac_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2013-11-06 00:10:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/14588009/1035001

[commit-bot: I haz the power, 2013-11-06 04:44:04]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 16:01:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/14588009/1035001

[commit-bot: I haz the power, 2013-11-06 20:19:56]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[dmichael (off chromium), 2013-11-06 21:02:15]

Committed patchset #10 manually as r233356 (presubmit successful).